Gendarme Report

Produced on 28.05.2010 08:19:35 UTC.

Table of contents

1.  Summary
  1.1.  List of assemblies searched
  1.2.  List of rules used
2.  Reported defects
  2.1. AvoidLackOfCohesionOfMethodsRule
  2.2. AvoidMethodWithUnusedGenericTypeRule
  2.3. AvoidRefAndOutParametersRule
  2.4. AvoidUncalledPrivateCodeRule
  2.5. AvoidUnnecessarySpecializationRule
  2.6. CheckParametersNullityInVisibleMethodsRule
  2.7. DoNotForgetNotImplementedMethodsRule
  2.8. DoNotSwallowErrorsCatchingNonSpecificExceptionsRule
  2.9. EnsureLocalDisposalRule
  2.10. PreferGenericsOverRefObjectRule
  2.11. ProvideCorrectArgumentsToFormattingMethodsRule
  2.12. TypesWithDisposableFieldsShouldBeDisposableRule
  2.13. UseStringEmptyRule

Summary

Gendarme found 67 potential defects using 187 rules.

List of assemblies analyzed [show]

List of rules used [show]

Reported Defects

1. AvoidLackOfCohesionOfMethodsRule [hide]

Problem:

The methods in this class lacks cohesion (higher score is better). This leads to code harder to understand and maintain.

Solution:

You can apply the Extract Class or Extract Subclass refactoring.

2 defect(s) found:

Target: NauckIT.PostgreSQLProvider.PgMembershipProvider
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈49)
Details: Type cohesiveness : 16%
Go to AvoidLackOfCohesionOfMethodsRule description

Target: NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈51)
Details: Type cohesiveness : 38%
Go to AvoidLackOfCohesionOfMethodsRule description

2. AvoidMethodWithUnusedGenericTypeRule [hide]

Problem:

The method parameters are not using all generic type parameters defined.

Solution:

Not infering all generic typers in the method parameters can lead to confusing, hard to use, API definitions.

5 defect(s) found:

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromBase64(System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈46)
Details: Generic parameter 'T' is not used by the method parameters.
Go to AvoidMethodWithUnusedGenericTypeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromXml(System.String,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈75)
Details: Generic parameter 'T' is not used by the method parameters.
Go to AvoidMethodWithUnusedGenericTypeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromXmlFile(System.String,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈86)
Details: Generic parameter 'T' is not used by the method parameters.
Go to AvoidMethodWithUnusedGenericTypeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromBinary(System.Byte[])
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈120)
Details: Generic parameter 'T' is not used by the method parameters.
Go to AvoidMethodWithUnusedGenericTypeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromBinaryFile(System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈129)
Details: Generic parameter 'T' is not used by the method parameters.
Go to AvoidMethodWithUnusedGenericTypeRule description

3. AvoidRefAndOutParametersRule [hide]

Problem:

This method use ref and/or out parameters in a visible API, which should be as simple as possible.

Solution:

If multiple return values are needed then refactor the method to return an object that contains them.

16 defect(s) found:

Target: System.Web.Security.MembershipUser NauckIT.PostgreSQLProvider.PgMembershipProvider::CreateUser(System.String,System.String,System.String,System.String,System.String,System.Boolean,System.Object,System.Web.Security.MembershipCreateStatus&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: status
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈315)
Details: Parameter 'status' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Security.MembershipUserCollection NauckIT.PostgreSQLProvider.PgMembershipProvider::FindUsersByEmail(System.String,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈468)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Security.MembershipUserCollection NauckIT.PostgreSQLProvider.PgMembershipProvider::FindUsersByName(System.String,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈555)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Security.MembershipUserCollection NauckIT.PostgreSQLProvider.PgMembershipProvider::GetAllUsers(System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈639)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::FindInactiveProfilesByUserName(System.Web.Profile.ProfileAuthenticationOption,System.String,System.DateTime,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈114)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::FindProfilesByUserName(System.Web.Profile.ProfileAuthenticationOption,System.String,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈119)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::GetAllInactiveProfiles(System.Web.Profile.ProfileAuthenticationOption,System.DateTime,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈124)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::GetAllProfiles(System.Web.Profile.ProfileAuthenticationOption,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: totalRecords
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈129)
Details: Parameter 'totalRecords' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.SessionState.SessionStateStoreData NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::GetItem(System.Web.HttpContext,System.String,System.Boolean&,System.TimeSpan&,System.Object&,System.Web.SessionState.SessionStateActions&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: locked
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈196)
Details: Parameter 'locked' passed by reference (out).

Severity: Medium Confidence: Total
Location: lockAge
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈196)
Details: Parameter 'lockAge' passed by reference (out).

Severity: Medium Confidence: Total
Location: lockId
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈196)
Details: Parameter 'lockId' passed by reference (out).

Severity: Medium Confidence: Total
Location: actions
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈196)
Details: Parameter 'actions' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

Target: System.Web.SessionState.SessionStateStoreData NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::GetItemExclusive(System.Web.HttpContext,System.String,System.Boolean&,System.TimeSpan&,System.Object&,System.Web.SessionState.SessionStateActions&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Total
Location: locked
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈204)
Details: Parameter 'locked' passed by reference (out).

Severity: Medium Confidence: Total
Location: lockAge
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈204)
Details: Parameter 'lockAge' passed by reference (out).

Severity: Medium Confidence: Total
Location: lockId
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈204)
Details: Parameter 'lockId' passed by reference (out).

Severity: Medium Confidence: Total
Location: actions
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈204)
Details: Parameter 'actions' passed by reference (out).
Go to AvoidRefAndOutParametersRule description

4. AvoidUncalledPrivateCodeRule [hide]

Problem:

This private or internal (assembly-level) member does not have callers in the assembly, is not invoked by the common language runtime, and is not invoked by a delegate.

Solution:

Remove the non-callable code or add the code that calls it.

4 defect(s) found:

Target: System.Void NauckIT.PostgreSQLProvider.SerializationHelper::SerializeToXmlFile(System.String,T,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈64)
Details: The method is not visible outside its declaring assembly, nor used within.
Go to AvoidUncalledPrivateCodeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromXmlFile(System.String,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈86)
Details: The method is not visible outside its declaring assembly, nor used within.
Go to AvoidUncalledPrivateCodeRule description

Target: System.Void NauckIT.PostgreSQLProvider.SerializationHelper::SerializeToBinaryFile(System.String,System.Object)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈109)
Details: The method is not visible outside its declaring assembly, nor used within.
Go to AvoidUncalledPrivateCodeRule description

Target: T NauckIT.PostgreSQLProvider.SerializationHelper::DeserializeFromBinaryFile(System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈129)
Details: The method is not visible outside its declaring assembly, nor used within.
Go to AvoidUncalledPrivateCodeRule description

5. AvoidUnnecessarySpecializationRule [hide]

Problem:

This method has a parameter whose type is more specialized than necessary. It can be harder to reuse and/or extend the method in derived types.

Solution:

Replace parameter type with the least specialized type necessary, or make use of the specifics of the actual parameter type.

1 defect(s) found:

Target: System.Web.Security.MembershipUser NauckIT.PostgreSQLProvider.PgMembershipProvider::GetUserFromReader(Npgsql.NpgsqlDataReader)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈1326)
Details: Parameter 'reader' could be of type 'System.Data.IDataRecord'.
Go to AvoidUnnecessarySpecializationRule description

6. CheckParametersNullityInVisibleMethodsRule [hide]

Problem:

A visible method does not check its parameter(s) for null values.

Solution:

Since the caller is unknown you should always verify all of your parameters to protect yourself.

7 defect(s) found:

Target: System.Web.Security.MembershipUserCollection NauckIT.PostgreSQLProvider.PgMembershipProvider::FindUsersByName(System.String,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Location: usernameToMatch
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈555)
Go to CheckParametersNullityInVisibleMethodsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgMembershipProvider::UpdateUser(System.Web.Security.MembershipUser)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Location: user
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈1160)
Go to CheckParametersNullityInVisibleMethodsRule description

Target: System.Configuration.SettingsPropertyValueCollection NauckIT.PostgreSQLProvider.PgProfileProvider::GetPropertyValues(System.Configuration.SettingsContext,System.Configuration.SettingsPropertyCollection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Location: context
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈148)

Severity: High Confidence: Normal
Location: collection
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈148)
Go to CheckParametersNullityInVisibleMethodsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgProfileProvider::SetPropertyValues(System.Configuration.SettingsContext,System.Configuration.SettingsPropertyValueCollection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Location: context
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈229)

Severity: High Confidence: Normal
Location: collection
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈229)
Go to CheckParametersNullityInVisibleMethodsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::SetAndReleaseItemExclusive(System.Web.HttpContext,System.String,System.Web.SessionState.SessionStateStoreData,System.Object,System.Boolean)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Location: item
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈404)
Go to CheckParametersNullityInVisibleMethodsRule description

7. DoNotForgetNotImplementedMethodsRule [hide]

Problem:

This method look like it is not implemented or incomplete.

Solution:

Implement the method and/or make sure it's limitation are well documented.

8 defect(s) found:

Target: System.Int32 NauckIT.PostgreSQLProvider.PgProfileProvider::DeleteInactiveProfiles(System.Web.Profile.ProfileAuthenticationOption,System.DateTime)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈99)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Int32 NauckIT.PostgreSQLProvider.PgProfileProvider::DeleteProfiles(System.String[])
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈104)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Int32 NauckIT.PostgreSQLProvider.PgProfileProvider::DeleteProfiles(System.Web.Profile.ProfileInfoCollection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈109)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::FindInactiveProfilesByUserName(System.Web.Profile.ProfileAuthenticationOption,System.String,System.DateTime,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈114)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::FindProfilesByUserName(System.Web.Profile.ProfileAuthenticationOption,System.String,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈119)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::GetAllInactiveProfiles(System.Web.Profile.ProfileAuthenticationOption,System.DateTime,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈124)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Web.Profile.ProfileInfoCollection NauckIT.PostgreSQLProvider.PgProfileProvider::GetAllProfiles(System.Web.Profile.ProfileAuthenticationOption,System.Int32,System.Int32,System.Int32&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈129)
Go to DoNotForgetNotImplementedMethodsRule description

Target: System.Int32 NauckIT.PostgreSQLProvider.PgProfileProvider::GetNumberOfInactiveProfiles(System.Web.Profile.ProfileAuthenticationOption,System.DateTime)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgProfileProvider.cs(≈134)
Go to DoNotForgetNotImplementedMethodsRule description

8. DoNotSwallowErrorsCatchingNonSpecificExceptionsRule [hide]

Problem:

The method catch a non-specific exception. This will likely hide the original problem to the callers.

Solution:

You can rethrow the original exception, to avoid destroying the stacktrace, or you can handle more specific exceptions.

16 defect(s) found:

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::CreateUninitializedItem(System.Web.HttpContext,System.String,System.Int32)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈179)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::RemoveItem(System.Web.HttpContext,System.String,System.Object,System.Web.SessionState.SessionStateStoreData)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈314)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈302)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::ResetItemTimeout(System.Web.HttpContext,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈377)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈365)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::SetAndReleaseItemExclusive(System.Web.HttpContext,System.String,System.Web.SessionState.SessionStateStoreData,System.Object,System.Boolean)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈478)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈466)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Boolean NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::CreateUninitializedItemTryInsert(System.String,System.Int32,Npgsql.NpgsqlConnection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈552)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Boolean NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::CreateUninitializedItemTryUpdate(System.String,System.Int32,Npgsql.NpgsqlConnection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈616)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Web.SessionState.SessionStateStoreData NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::GetSessionStoreItem(System.Boolean,System.Web.HttpContext,System.String,System.Boolean&,System.TimeSpan&,System.Object&,System.Web.SessionState.SessionStateActions&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈740)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈728)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::InvokeExpireCallbackAndDeleteSession()
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈873)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈924)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈912)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

Target: System.Void NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::DeleteExpiredSessionsFromDatabase()
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈986)

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈974)
Go to DoNotSwallowErrorsCatchingNonSpecificExceptionsRule description

9. EnsureLocalDisposalRule [hide]

Problem:

This disposable local is not guaranteed to be disposed of before the method returns.

Solution:

Use a 'using' statement or surround the local's usage with a try/finally block.

2 defect(s) found:

Target: System.String NauckIT.PostgreSQLProvider.PgMembershipProvider::EncodePassword(System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈1408)
Details: Local 'hash' of type 'HMACSHA1' is not disposed of (at least not locally).
Go to EnsureLocalDisposalRule description

Target: System.String NauckIT.PostgreSQLProvider.SerializationHelper::SerializeToXml(T,System.String)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\SerializationHelper.cs(≈56)
Details: Local 'xmlWriter' of type 'XmlTextWriter' is not disposed of (at least not locally).
Go to EnsureLocalDisposalRule description

10. PreferGenericsOverRefObjectRule [hide]

Problem:

This method contains an object reference parameter that could be changed into a generic.

Solution:

Change the parameter to use a generic type where the caller will provide the type.

3 defect(s) found:

Target: System.Web.SessionState.SessionStateStoreData NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::GetSessionStoreItem(System.Boolean,System.Web.HttpContext,System.String,System.Boolean&,System.TimeSpan&,System.Object&,System.Web.SessionState.SessionStateActions&)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Location: lockId
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈651)
Go to PreferGenericsOverRefObjectRule description

11. ProvideCorrectArgumentsToFormattingMethodsRule [hide]

Problem:

You are calling to a Format method without the correct arguments. This could throw an unexpected FormatException.

Solution:

Pass the correct arguments to the formatting method.

1 defect(s) found:

Target: System.Void NauckIT.PostgreSQLProvider.PgMembershipProvider::Initialize(System.String,System.Collections.Specialized.NameValueCollection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: Normal
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈119)
Details: Extra parameters
Go to ProvideCorrectArgumentsToFormattingMethodsRule description

12. TypesWithDisposableFieldsShouldBeDisposableRule [hide]

Problem:

This type contains disposable field(s) but doesn't implement IDisposable.

Solution:

Implement IDisposable and free the disposable field(s) in its Dispose method.

1 defect(s) found:

Target: NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: High Confidence: High
Location: System.Timers.Timer NauckIT.PostgreSQLProvider.PgSessionStateStoreProvider::m_expiredSessionDeletionTimer
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgSessionStateStoreProvider.cs(≈51)
Details: Field implement IDisposable. Type should implement a Dispose() method
Go to TypesWithDisposableFieldsShouldBeDisposableRule description

13. UseStringEmptyRule [hide]

Problem:

The method uses literal "" instead of String.Empty.

Solution:

Change the empty string literal for String.Empty.

1 defect(s) found:

Target: System.Void NauckIT.PostgreSQLProvider.PgMembershipProvider::Initialize(System.String,System.Collections.Specialized.NameValueCollection)
Assembly: NauckIT.PostgreSQLProvider, Version=1.3.2.0, Culture=neutral, PublicKeyToken=e179b4c7dfb3984c

Severity: Medium Confidence: High
Source: d:\Build\Projects\AspSQLProvider\SCM\src\NauckIT.PostgreSQLProvider\PgMembershipProvider.cs(≈81)
Go to UseStringEmptyRule description