Build (ForceBuild) triggered from BUILD D:\Build\Projects\NetReflector\Logs\ ForceBuild 2010-03-19 14:54:24 Success 1.0.17.58 Success D:\Build\Projects\NetReflector\Logs\NetReflector_ListenFile.xml 58 NetReflector http://build.nauck-it.de/server/build.nauck-it.de/project/NetReflector/ViewProjectReport.aspx BUILD D:\Build\Projects\NetReflector\ Success 1.0.17.58 18.03.2010 14:55:36 0 0 0 0 0 0 0 0 0 15.625 0 0 0 0 0 0 0 0 0 0 0 0 15.625 0 0 0 15.625 0 0 0 62.5 109.375 218.75 0 0 15.625 515.625 578.125 375 0 15.625 0 0 0 D:\Build\Projects\NetReflector\SCM\Build\NetReflector.dll]]> D:\Build\Projects\NetReflector\SCM\Build\NetReflectorDocumenterTask.dll]]> D:\Build\Projects\NetReflector\SCM\Build\NetReflectorPlugin.Test.dll]]> D:\Build\Projects\NetReflector\SCM\Build\NetReflector.Test.dll]]> 7781.25 8218.75 0 10265.625 10296.875 10296.875 10296.875 0 0 0 0 0 10765.625 10796.875 10796.875 0 15.625 0 0 0 0 0 0 0 9312.5 9343.75 9343.75 9375 20187.5 0 11890.625 11968.75 11968.75 0 31.25 62.5 62.5 12031.25 0 51734.375 D:\Build\Projects\NetReflector\SCM\Build\NetReflector.dll D:\Build\Projects\NetReflector\SCM\Build\NetReflectorDocumenterTask.dll Gendarme.Rules.BadPractice.AvoidAssemblyVersionMismatchRule Gendarme.Rules.BadPractice.AvoidCallingProblematicMethodsRule Gendarme.Rules.BadPractice.AvoidVisibleConstantFieldRule Gendarme.Rules.BadPractice.CheckNewExceptionWithoutThrowingRule Gendarme.Rules.BadPractice.CheckNewThreadWithoutStartRule Gendarme.Rules.BadPractice.CloneMethodShouldNotReturnNullRule Gendarme.Rules.BadPractice.ConstructorShouldNotCallVirtualMethodsRule Gendarme.Rules.BadPractice.DisableDebuggingCodeRule Gendarme.Rules.BadPractice.DoNotForgetNotImplementedMethodsRule Gendarme.Rules.BadPractice.DoNotUseGetInterfaceToCheckAssignabilityRule Gendarme.Rules.BadPractice.EqualsShouldHandleNullArgRule Gendarme.Rules.BadPractice.GetEntryAssemblyMayReturnNullRule Gendarme.Rules.BadPractice.ObsoleteMessagesShouldNotBeEmptyRule Gendarme.Rules.BadPractice.PreferEmptyInstanceOverNullRule Gendarme.Rules.BadPractice.ReplaceIncompleteOddnessCheckRule Gendarme.Rules.BadPractice.ToStringShouldNotReturnNullRule Gendarme.Rules.Concurrency.DoNotLockOnThisOrTypesRule Gendarme.Rules.Concurrency.DoNotLockOnWeakIdentityObjectsRule Gendarme.Rules.Concurrency.DoNotUseMethodImplOptionsSynchronizedRule Gendarme.Rules.Concurrency.DoNotUseLockedRegionOutsideMethodRule Gendarme.Rules.Concurrency.DoubleCheckLockingRule Gendarme.Rules.Concurrency.NonConstantStaticFieldsShouldNotBeVisibleRule Gendarme.Rules.Concurrency.ProtectCallToEventDelegatesRule Gendarme.Rules.Concurrency.ReviewLockUsedOnlyForOperationsOnVariablesRule Gendarme.Rules.Concurrency.WriteStaticFieldFromInstanceMethodRule Gendarme.Rules.Correctness.AttributeStringLiteralsShouldParseCorrectlyRule Gendarme.Rules.Correctness.AvoidConstructorsInStaticTypesRule Gendarme.Rules.Correctness.AvoidFloatingPointEqualityRule Gendarme.Rules.Correctness.DoNotRecurseInEqualityRule Gendarme.Rules.Correctness.BadRecursiveInvocationRule Gendarme.Rules.Correctness.CallingEqualsWithNullArgRule Gendarme.Rules.Correctness.CheckParametersNullityInVisibleMethodsRule Gendarme.Rules.Correctness.DisposableFieldsShouldBeDisposedRule Gendarme.Rules.Correctness.DoNotRoundIntegersRule Gendarme.Rules.Correctness.DoNotCompareWithNaNRule Gendarme.Rules.Correctness.EnsureLocalDisposalRule Gendarme.Rules.Correctness.FinalizersShouldCallBaseClassFinalizerRule Gendarme.Rules.Correctness.ReviewInconsistentIdentityRule Gendarme.Rules.Correctness.MethodCanBeMadeStaticRule Gendarme.Rules.Correctness.ProvideCorrectArgumentsToFormattingMethodsRule Gendarme.Rules.Correctness.ProvideCorrectRegexPatternRule Gendarme.Rules.Correctness.ReviewCastOnIntegerDivisionRule Gendarme.Rules.Correctness.ReviewCastOnIntegerMultiplicationRule Gendarme.Rules.Correctness.ReviewDoubleAssignmentRule Gendarme.Rules.Correctness.ReviewSelfAssignmentRule Gendarme.Rules.Correctness.ReviewUselessControlFlowRule Gendarme.Rules.Correctness.ReviewUseOfInt64BitsToDoubleRule Gendarme.Rules.Correctness.ReviewUseOfModuloOneOnIntegersRule Gendarme.Rules.Correctness.UseValueInPropertySetterRule Gendarme.Rules.Design.AbstractTypesShouldNotHavePublicConstructorsRule Gendarme.Rules.Design.AttributeArgumentsShouldHaveAccessorsRule Gendarme.Rules.Design.AvoidEmptyInterfaceRule Gendarme.Rules.Design.AvoidMultidimensionalIndexerRule Gendarme.Rules.Design.AvoidPropertiesWithoutGetAccessorRule Gendarme.Rules.Design.AvoidVisibleFieldsRule Gendarme.Rules.Design.AvoidRefAndOutParametersRule Gendarme.Rules.Design.AvoidSmallNamespaceRule Gendarme.Rules.Design.AvoidVisibleNestedTypesRule Gendarme.Rules.Design.ConsiderAddingInterfaceRule Gendarme.Rules.Design.ConsiderConvertingFieldToNullableRule Gendarme.Rules.Design.ConsiderConvertingMethodToPropertyRule Gendarme.Rules.Design.ConsiderUsingStaticTypeRule Gendarme.Rules.Design.DeclareEventHandlersCorrectlyRule Gendarme.Rules.Design.DisposableTypesShouldHaveFinalizerRule Gendarme.Rules.Design.DoNotDeclareVirtualMethodsInSealedTypeRule Gendarme.Rules.Design.DoNotDeclareProtectedMembersInSealedTypeRule Gendarme.Rules.Design.EnsureSymmetryForOverloadedOperatorsRule Gendarme.Rules.Design.EnumsShouldDefineAZeroValueRule Gendarme.Rules.Design.EnumsShouldUseInt32Rule Gendarme.Rules.Design.FinalizersShouldBeProtectedRule Gendarme.Rules.Design.FlagsShouldNotDefineAZeroValueRule Gendarme.Rules.Design.ImplementEqualsAndGetHashCodeInPairRule Gendarme.Rules.Design.ImplementIComparableCorrectlyRule Gendarme.Rules.Design.InternalNamespacesShouldNotExposeTypesRule Gendarme.Rules.Design.MainShouldNotBePublicRule Gendarme.Rules.Design.MarkAssemblyWithAssemblyVersionRule Gendarme.Rules.Design.MarkAssemblyWithCLSCompliantRule Gendarme.Rules.Design.MarkAssemblyWithComVisibleRule Gendarme.Rules.Design.MissingAttributeUsageOnCustomAttributeRule Gendarme.Rules.Design.OperatorEqualsShouldBeOverloadedRule Gendarme.Rules.Design.OverrideEqualsMethodRule Gendarme.Rules.Design.PreferEventsOverMethodsRule Gendarme.Rules.Design.PreferIntegerOrStringForIndexersRule Gendarme.Rules.Design.ProvideAlternativeNamesForOperatorOverloadsRule Gendarme.Rules.Design.TypesShouldBeInsideNamespacesRule Gendarme.Rules.Design.TypesWithDisposableFieldsShouldBeDisposableRule Gendarme.Rules.Design.TypesWithNativeFieldsShouldBeDisposableRule Gendarme.Rules.Design.UseFlagsAttributeRule Gendarme.Rules.Design.Generic.AvoidMethodWithUnusedGenericTypeRule Gendarme.Rules.Design.Generic.DoNotExposeNestedGenericSignaturesRule Gendarme.Rules.Design.Generic.ImplementGenericCollectionInterfacesRule Gendarme.Rules.Design.Generic.PreferGenericsOverRefObjectRule Gendarme.Rules.Design.Generic.UseGenericEventHandlerRule Gendarme.Rules.Design.Linq.AvoidExtensionMethodOnSystemObjectRule Gendarme.Rules.Exceptions.AvoidArgumentExceptionDefaultConstructorRule Gendarme.Rules.Exceptions.AvoidThrowingBasicExceptionsRule Gendarme.Rules.Exceptions.DoNotDestroyStackTraceRule Gendarme.Rules.Exceptions.DoNotThrowInUnexpectedLocationRule Gendarme.Rules.Exceptions.DoNotThrowReservedExceptionRule Gendarme.Rules.Exceptions.DoNotSwallowErrorsCatchingNonSpecificExceptionsRule Gendarme.Rules.Exceptions.ExceptionShouldBeVisibleRule Gendarme.Rules.Exceptions.InstantiateArgumentExceptionCorrectlyRule Gendarme.Rules.Exceptions.MissingExceptionConstructorsRule Gendarme.Rules.Interoperability.DoNotAssumeIntPtrSizeRule Gendarme.Rules.Interoperability.GetLastErrorMustBeCalledRightAfterPInvokeRule Gendarme.Rules.Interoperability.MarshalBooleansInPInvokeDeclarationsRule Gendarme.Rules.Interoperability.MarshalStringsInPInvokeDeclarationsRule Gendarme.Rules.Interoperability.PInvokeShouldNotBeVisibleRule Gendarme.Rules.Interoperability.UseManagedAlternativesToPInvokeRule Gendarme.Rules.Naming.AvoidDeepNamespaceHierarchyRule Gendarme.Rules.Naming.AvoidRedundancyInMethodNameRule Gendarme.Rules.Naming.AvoidRedundancyInTypeNameRule Gendarme.Rules.Naming.AvoidTypeInterfaceInconsistencyRule Gendarme.Rules.Naming.AvoidNonAlphanumericIdentifierRule Gendarme.Rules.Naming.DoNotPrefixEventsWithAfterOrBeforeRule Gendarme.Rules.Naming.DoNotPrefixValuesWithEnumNameRule Gendarme.Rules.Naming.DoNotUseReservedInEnumValueNamesRule Gendarme.Rules.Naming.ParameterNamesShouldMatchOverriddenMethodRule Gendarme.Rules.Naming.UseCorrectCasingRule Gendarme.Rules.Naming.UseCorrectPrefixRule Gendarme.Rules.Naming.UseCorrectSuffixRule Gendarme.Rules.Naming.UsePluralNameInEnumFlagsRule Gendarme.Rules.Naming.UsePreferredTermsRule Gendarme.Rules.Naming.UseSingularNameInEnumsUnlessAreFlagsRule Gendarme.Rules.Performance.AvoidLargeNumberOfLocalVariablesRule Gendarme.Rules.Performance.AvoidLargeStructureRule Gendarme.Rules.Performance.AvoidRepetitiveCastsRule Gendarme.Rules.Performance.AvoidReturningArraysOnPropertiesRule Gendarme.Rules.Performance.AvoidTypeGetTypeForConstantStringsRule Gendarme.Rules.Performance.AvoidUncalledPrivateCodeRule Gendarme.Rules.Performance.AvoidUninstantiatedInternalClassesRule Gendarme.Rules.Performance.AvoidUnneededCallsOnStringRule Gendarme.Rules.Performance.AvoidUnneededFieldInitializationRule Gendarme.Rules.Performance.AvoidUnneededUnboxingRule Gendarme.Rules.Performance.AvoidUnsealedConcreteAttributesRule Gendarme.Rules.Performance.AvoidUnsealedUninheritedInternalTypeRule Gendarme.Rules.Performance.AvoidUnusedParametersRule Gendarme.Rules.Performance.AvoidUnusedPrivateFieldsRule Gendarme.Rules.Performance.CompareWithEmptyStringEfficientlyRule Gendarme.Rules.Performance.ConsiderCustomAccessorsForNonVisibleEventsRule Gendarme.Rules.Performance.DoNotIgnoreMethodResultRule Gendarme.Rules.Performance.RemoveUnneededFinalizerRule Gendarme.Rules.Performance.UseSuppressFinalizeOnIDisposableTypeWithFinalizerRule Gendarme.Rules.Performance.ImplementEqualsTypeRule Gendarme.Rules.Performance.MathMinMaxCandidateRule Gendarme.Rules.Performance.OverrideValueTypeDefaultsRule Gendarme.Rules.Performance.PreferCharOverloadRule Gendarme.Rules.Performance.PreferLiteralOverInitOnlyFieldsRule Gendarme.Rules.Performance.RemoveUnusedLocalVariablesRule Gendarme.Rules.Performance.UseIsOperatorRule Gendarme.Rules.Performance.UseStringEmptyRule Gendarme.Rules.Performance.UseTypeEmptyTypesRule Gendarme.Rules.Portability.DoNotHardcodePathsRule Gendarme.Rules.Portability.ExitCodeIsLimitedOnUnixRule Gendarme.Rules.Portability.FeatureRequiresRootPrivilegeOnUnixRule Gendarme.Rules.Portability.MonoCompatibilityReviewRule Gendarme.Rules.Portability.NewLineLiteralRule Gendarme.Rules.Security.ArrayFieldsShouldNotBeReadOnlyRule Gendarme.Rules.Security.DoNotShortCircuitCertificateCheckRule Gendarme.Rules.Security.NativeFieldsShouldNotBeVisibleRule Gendarme.Rules.Security.StaticConstructorsShouldBePrivateRule Gendarme.Rules.Security.Cas.AddMissingTypeInheritanceDemandRule Gendarme.Rules.Security.Cas.DoNotExposeFieldsInSecuredTypeRule Gendarme.Rules.Security.Cas.DoNotExposeMethodsProtectedByLinkDemandRule Gendarme.Rules.Security.Cas.DoNotReduceTypeSecurityOnMethodsRule Gendarme.Rules.Security.Cas.ReviewNonVirtualMethodWithInheritanceDemandRule Gendarme.Rules.Security.Cas.ReviewSealedTypeWithInheritanceDemandRule Gendarme.Rules.Security.Cas.ReviewSuppressUnmanagedCodeSecurityUsageRule Gendarme.Rules.Security.Cas.SecureGetObjectDataOverridesRule Gendarme.Rules.Serialization.CallBaseMethodsOnISerializableTypesRule Gendarme.Rules.Serialization.DeserializeOptionalFieldRule Gendarme.Rules.Serialization.ImplementISerializableCorrectlyRule Gendarme.Rules.Serialization.MarkAllNonSerializableFieldsRule Gendarme.Rules.Serialization.MarkEnumerationsAsSerializableRule Gendarme.Rules.Serialization.MissingSerializableAttributeOnISerializableTypeRule Gendarme.Rules.Serialization.MissingSerializationConstructorRule Gendarme.Rules.Serialization.UseCorrectSignatureForSerializationMethodsRule Gendarme.Rules.UI.GtkSharpExecutableTargetRule Gendarme.Rules.UI.SystemWindowsFormsExecutableTargetRule Gendarme.Rules.UI.UseSTAThreadAttributeOnSWFEntryPointsRule Gendarme.Rules.Maintainability.AvoidAlwaysNullFieldRule Gendarme.Rules.Maintainability.AvoidComplexMethodsRule Gendarme.Rules.Maintainability.AvoidDeepInheritanceTreeRule Gendarme.Rules.Maintainability.AvoidLackOfCohesionOfMethodsRule Gendarme.Rules.Maintainability.AvoidUnnecessarySpecializationRule Gendarme.Rules.Maintainability.ConsiderUsingStopwatchRule Gendarme.Rules.Maintainability.PreferStringIsNullOrEmptyRule All parameter values passed to this type constructors should be visible through read-only properties. Add the missing properties getters to this type. Add 'FactoryType' property to the attribute class. Add 'Name' property to the attribute class. Add 'Name' property to the attribute class. Add 'Name' property to the attribute class. There are potentially dangerous calls into your code. You should remove or replace the call to the dangerous method. You are calling to System.Reflection.Assembly System.Reflection.Assembly::LoadFrom(System.String), which is a potentially problematic method The methods in this class lacks cohesion (higher score is better). This leads to code harder to understand and maintain. You can apply the Extract Class or Extract Subclass refactoring. Type cohesiveness : 14% Type cohesiveness : 33% Type cohesiveness : 27% Type cohesiveness : 20% Type cohesiveness : 38% Type cohesiveness : 28% This type name is prefixed with the last component of its enclosing namespace. This usually makes an API more verbose and less autocompletion-friendly than necessary. Rename type without the prefix or replace it with a more meaningful term in the context of the namespace. Consider renaming type to 'Writer'. Consider renaming type to 'Reader'. Consider renaming type to 'ConverterException'. Consider renaming type to 'ItemRequiredException'. Consider renaming type to 'TypeTable'. The method seems to repeat the same cast operation multiple times. Change the logic to ensure the (somewhat expensive) cast is done once. 'CS$5$0001' is casted 2 times for type 'System.IDisposable'. 'CS$5$0000' is casted 2 times for type 'System.IDisposable'. This method has a parameter whose type is more specialized than necessary. It can be harder to reuse and/or extend the method in derived types. Replace parameter type with the least specialized type necessary, or make use of the specifics of the actual parameter type. Parameter 'member' could be of type 'System.Reflection.ICustomAttributeProvider'. Parameter 'type' could be of type 'System.Reflection.ICustomAttributeProvider'. Parameter 'type' could be of type 'System.Reflection.MemberInfo'. Parameter 'item' could be of type 'System.Xml.Schema.XmlSchemaAnnotated'. Parameter 'expected' could be of type 'System.Reflection.MemberInfo'. This method needlessly calls some method(s) on a string instance. This may produce some performance penalities. Remove the unneeded call(s) on the string instance. There is no need to call ToString() on a System.String instance. Due performance issues, concrete attributes should be sealed. Unless you plan to inherit from this attribute you should consider to seal it's type. Due to performance issues, types which are not visible outside of the assembly and which have no inherited types within the assembly should be sealed. You should seal this type, unless you plan to inherit from this type in the near-future. A visible method does not check its parameter(s) for null values. Since the caller is unknown you should always verify all of your parameters to protect yourself. This type contains only static fields and methods and should be static. Change this type into a static type to gain clarity and better error reporting. The delegate which handles the event haven't the correct signature. You should correct the signature, return type, parameter types or parameter names. The delegate should have 2 parameters The first parameter should have an object, not Exortech.NetReflector.InvalidNodeEventArgs The method catch a non-specific exception. This will likely hide the original problem to the callers. You can rethrow the original exception, to avoid destroying the stacktrace, or you can handle more specific exceptions. A method throws an exception it should not. Change the code so that it does not throw, throw a correct exception, or trap exceptions. Indexed getters should only throw System.InvalidOperationException, System.NotSupportedException, System.ArgumentException, System.Collections.Generic.KeyNotFoundException or a subclass. This disposable local is not guaranteed to be disposed of before the method returns. Use a 'using' statement or surround the local's usage with a try/finally block. Local 'xmlWriter' of type 'XmlTextWriter' is not disposed of (at least not locally). Local 'buffer' of type 'StringWriter' is not disposed of (at least not locally). This type implements non-generic IEnumerable interface but does not implement IEnumerable<T> interface that will make your collection type-safe. Implement one of generic collection interfaces such as IEnumerable<T>, ICollection<T> or IList<T>. This method throws ArgumentException (or derived) exceptions without specifying an existing parameter name. This can hide useful information to developers. Fix the exception parameters to use the correct parameter name (or make sure the parameters are in the right order). This assembly is not decorated with the [CLSCompliant] attribute. Add this attribute to ease the use (or non-use) of your assembly by CLS consumers. This assembly is not decorated with the [ComVisible] attribute. Add this attribute to ease the use (or non-use) of your assembly by COM consumers. This method overrides (or implement) an existing method but does not use the same parameter names as the original. Keep parameter names consistent when overriding a class or implementing an interface. The name of parameter #1 (member) does not match the name of the parameter in the overriden method (memberInfo). The name of parameter #1 (node) does not match the name of the parameter in the overriden method (childNode). The name of parameter #1 (node) does not match the name of the parameter in the overriden method (childNode). Static readonly fields were found where a literal (const) field could be used. Replace the static readonly fields with const(ant) fields. This type contains disposable field(s) but doesn't implement IDisposable. Implement IDisposable and free the disposable field(s) in its Dispose method. Field implement IDisposable. Type should implement a Dispose() method This type does not end with the correct suffix. That usually happens when you define a custom attribute or exception and forget appending suffixes like 'Attribute' or 'Exception' to the type name. Rename the type and append the correct suffix. 'IReflectorAttribute' should only be used for types that inherits or implements System.Attribute. The type name does not end with 'Collection' suffix. Append it to the type name. The type name does not end with 'Collection' suffix. Append it to the type name. Consider merging the types defined in 'Exortech.NetReflector.Generators' with another namespace. In member 'DefaultSerialiserFactory.Create(ReflectorMember, ReflectorPropertyAttribute)', change parameter name 'member' to 'memberInfo' in order to match the identifier as it has been declared in 'ISerialiserFactory.Create(ReflectorMember, ReflectorPropertyAttribute)'. Modify member 'InvalidNodeEventArgs.InvalidNodeEventArgs(XmlNode, string)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because field 'InvalidNodeEventArgs.Message' is visible outside of its declaring type, change its accessibility to private and add a property, with the same accessibility as the field has currently, to provide access to it. Remove the read-only designation from 'InvalidNodeEventArgs.Node' or change the field to one that is an immutable reference type. If the reference type 'XmlNode' is, in fact, immutable, exclude this message. Because field 'InvalidNodeEventArgs.Node' is visible outside of its declaring type, change its accessibility to private and add a property, with the same accessibility as the field has currently, to provide access to it. Modify member 'InvalidNodeEventArgs.Node' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'InvalidNodeEventArgs.ToString()' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Modify member 'IXmlSerialiser.Read(XmlNode, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Remove the public constructors from 'NetReflector'. The type name 'NetReflector' conflicts in whole or in part with the namespace name 'Exortech.NetReflector'. Change either name to eliminate the conflict. Consider changing the type of parameter 'expected' in 'NetReflector.CheckNull(object, string, Type)' from 'Type' to its base type 'MemberInfo'. This method appears to only require base class members in its implementation. Suppress this violation if there is a compelling reason to require the more derived type in the method signature. In member 'NetReflector.CheckNull(object, string, Type)', consider replacing the data type identifier 'obj' in parameter name 'obj' with a more generic term, such as 'value'. Because the behavior of 'string.Format(string, object)' could vary based on the current user's locale settings, replace this call in 'NetReflector.CheckNull(object, string, Type)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Modify member 'NetReflector.Read(XmlNode)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'NetReflector.Read(XmlNode, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'NetReflector.Read(XmlNode, object)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'NetReflector.Read(XmlNode, object, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because the behavior of 'StringWriter.StringWriter()' could vary based on the current user's locale settings, replace this call in 'NetReflector.Write(object)' with a call to 'StringWriter.StringWriter(IFormatProvider)'. If the result of 'StringWriter.StringWriter(IFormatProvider)' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Change the base type of 'NetReflectorException' so that it no longer extends 'ApplicationException'. This base exception type does not provide any additional value for framework classes. Extend 'System.Exception' or an existing unsealed exception type instead. Do not create a new exception base type unless there is specific value in enabling the creation of a catch handler for an entire class of exceptions. Modify member 'NetReflectorReader.Read(XmlNode)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'NetReflectorReader.Read(XmlNode)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Modify member 'NetReflectorReader.Read(XmlNode, object)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. 'NetReflectorTypeTable' appears to be a non-generic, strongly typed collection. Add an implementation to the instance of IEnumerable<T> where T is the underlying element type of 'NetReflectorTypeTable'. In member 'NetReflectorTypeTable.Add(string)', the discrete term 'Filename' in parameter name 'assemblyFilename' should be expressed as a compound word, 'FileName'. Because the behavior of 'string.Format(string, object, object, object)' could vary based on the current user's locale settings, replace this call in 'NetReflectorTypeTable.Add(Type)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. The 'this' parameter (or 'Me' in Visual Basic) of 'NetReflectorTypeTable.GetTypes(Assembly)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. Declare the first parameter of 'InvalidNodeEventHandler' as an object named 'sender'. Declare the second parameter of 'InvalidNodeEventHandler' as an EventArgs, or an instance of a type that extends EventArgs, named 'e'. Implement IDisposable on 'NetReflectorWriter' because it creates members of the following IDisposable types: 'XmlTextWriter'. If 'NetReflectorWriter' has previously shipped, adding new members that implement IDisposable to this type is considered a breaking change to existing consumers. Because the behavior of 'string.Format(string, object)' could vary based on the current user's locale settings, replace this call in 'NetReflectorWriter.Write(object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Seal 'ReflectionPreprocessorAttribute', if possible. Modify member 'ReflectionPreprocessorAttribute.Invoke(object, NetReflectorTypeTable, XmlNode)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'ReflectionPreprocessorAttribute.Invoke(object, NetReflectorTypeTable, XmlNode)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Remove the property setter from 'ReflectorHashAttribute.Key' or reduce its accessibility because it corresponds to positional argument 'key'. Seal 'ReflectorPropertyAttribute', if possible. Add a public read-only property accessor for positional argument 'factoryType' of Attribute 'ReflectorPropertyAttribute'. Remove the property setter from 'ReflectorPropertyAttribute.Name' or reduce its accessibility because it corresponds to positional argument 'name'. Remove the property setter from 'ReflectorTypeAttribute.Name' or reduce its accessibility because it corresponds to positional argument 'name'. Consider changing the type of parameter 'type' in 'ReflectorTypeAttribute.GetAttribute(Type)' from 'Type' to its base type 'MemberInfo'. This method appears to only require base class members in its implementation. Suppress this violation if there is a compelling reason to require the more derived type in the method signature. Remove the read-only designation from 'XmlArraySerialiser.converter' or change the field to one that is an immutable reference type. If the reference type 'ReflectorTypeConverter' is, in fact, immutable, exclude this message. Because field 'XmlArraySerialiser.converter' is visible outside of its declaring type, change its accessibility to private and add a property, with the same accessibility as the field has currently, to provide access to it. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlArraySerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, object, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlArraySerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Field 'XmlCollectionSerialiser.elementName' is declared as 'static readonly' but is initialized with a constant value 'string'. Mark this field as 'const' instead. In member 'XmlCollectionSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)', change parameter name 'node' to 'childNode' in order to match the identifier as it has been declared in 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)'. Because the behavior of 'string.Format(string, object, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlCollectionSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. In member 'XmlDictionarySerialiser.Read(XmlNode, Type, NetReflectorTypeTable)', change parameter name 'node' to 'childNode' in order to match the identifier as it has been declared in 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)'. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlMemberSerialiser.CheckIfMemberIsRequired()' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlMemberSerialiser.GetTargetType(XmlNode, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Modify member 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because the behavior of 'string.Format(string, object, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings, replace this call in 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, params object[])' could vary based on the current user's locale settings, replace this call in 'XmlMemberSerialiser.Read(XmlNode, Type, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. The 'this' parameter (or 'Me' in Visual Basic) of 'XmlMemberSerialiser.ReadValue(XmlNode, NetReflectorTypeTable)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. Modify member 'XmlMemberSerialiser.ReadValue(XmlNode, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. The 'this' parameter (or 'Me' in Visual Basic) of 'XmlTypeSerialiser.GetNodeByName(IList, string)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. The 'this' parameter (or 'Me' in Visual Basic) of 'XmlTypeSerialiser.HandleUnusedNode(NetReflectorTypeTable, XmlNode)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. Modify member 'XmlTypeSerialiser.ReadMembers(XmlNode, object, NetReflectorTypeTable)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'XmlTypeSerialiser.ReadMembers(XmlNode, object, NetReflectorTypeTable)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Consider changing the type of parameter 'type' in 'XmlDocumentationGenerator.WriteIfNotNull(XmlWriter, string, Type)' from 'Type' to its base type 'MemberInfo'. This method appears to only require base class members in its implementation. Suppress this violation if there is a compelling reason to require the more derived type in the method signature. 'XsdGenerator.GenerateElementType(Type, XmlSchemaElement, bool)' makes a call to 'string.EndsWith(string)' that does not explicitly provide a StringComparison. This should be replaced with a call to 'string.EndsWith(string, StringComparison)'. The 'this' parameter (or 'Me' in Visual Basic) of 'XsdGenerator.GenerateItemName(Type)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. Change the type of property 'XsdGenerator.NamespaceUri' from string to System.Uri. Because the behavior of 'string.Format(string, object)' could vary based on the current user's locale settings, replace this call in 'XsdTypes.this.get(Type)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. In method 'ReflectionUtil.IsCommonType(Type)', consider providing a more meaningful name than parameter name 't'. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'ReflectorMember.ReflectorField.SetValue(object, object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'ReflectorMember.ReflectorProperty.SetValue(object, object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, object, object)' could vary based on the current user's locale settings, replace this call in 'ReflectorMember.ReflectorProperty.SetValue(object, object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. Because the behavior of 'string.Format(string, object, object, object)' could vary based on the current user's locale settings, replace this call in 'ReflectorTypeConverter.Convert(Type, object)' with a call to 'string.Format(IFormatProvider, string, params object[])'. If the result of 'string.Format(IFormatProvider, string, params object[])' will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. The 'this' parameter (or 'Me' in Visual Basic) of 'ReflectorTypeConverter.IsCompatibleType(Type, object)' is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. In method 'StringUtil.EqualsIgnoreCase(string, string)', consider providing a more meaningful name than parameter name 'a'. In method 'StringUtil.EqualsIgnoreCase(string, string)', consider providing a more meaningful name than parameter name 'b'. Change either member or parameter name 'format' so that one differs from the other. In member 'StringUtil.Join(string, object[])', consider replacing the data type identifier 'objects' in parameter name 'objects' with a more generic term, such as 'value'. 'XmlElementList' appears to be a non-generic, strongly typed collection. Add an implementation to the instance of IEnumerable<T> where T is the underlying element type of 'XmlElementList'. Remove the public constructors from 'XmlUtil'. Modify member 'XmlUtil.GetChildNode(XmlNode, string)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'XmlUtil.GetChildNode(XmlNode, string)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'XmlUtil.ReadNode(string)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Modify member 'XmlUtil.ReadNode(XmlReader)' so that it no longer exposes the concrete type 'XmlNode'. Use IXPathNavigable to represent XML data sources. Sign 'NetReflectorDocumenterTask.dll' with a strong name key. Mark 'NetReflectorDocumenterTask.dll' with CLSCompliant(true) because it exposes externally visible types. Because 'NetReflectorDocumenterTask.dll' exposes externally visible types, mark it with ComVisible(false) at the assembly level and then mark all types within the assembly that should be exposed to COM clients with ComVisible(true). 'NetReflectorDocumenterTask' is marked ComVisible(true) but has the following ComVisible(false) types in its object hierarchy: NAnt.Core.Task, NAnt.Core.Element The type name 'NetReflectorDocumenterTask' conflicts in whole or in part with the namespace name 'NetReflectorDocumenterTask'. Change either name to eliminate the conflict. Assemblies should have valid strong names Either the assembly has no strong name, an invalid one, or the strong name is valid only because of the computer configuration. The assembly should not be deployed in this state. The most common causes of this are: 1) The assembly's contents were modified after it was signed. 2) The signing process failed. 3) The assembly was delay-signed. 4) A registry key existed that allowed the check to pass (where it would not have otherwise). Sign {0} with a strong name key. http://msdn2.microsoft.com/library/ms182127(VS.90).aspx [none] CriticalError Avoid namespaces with few types A namespace should generally have more than five types. Consider merging the types defined in '{0}' with another namespace. http://msdn2.microsoft.com/library/ms182130(VS.90).aspx [none] Warning Avoid unsealed attributes Seal attribute types for improved performance. Sealing attribute types speeds up performance during reflection on custom attributes. Seal {0}, if possible. http://msdn2.microsoft.com/library/ms182267(VS.90).aspx [none] Warning Collections should implement generic interface Non-generic strongly typed collections should implement one of the generic collection interfaces. This will allow better integration of the collection with generic API. {0} appears to be a non-generic, strongly typed collection. Add an implementation to the instance of {1}<T> where T is the underlying element type of {0}. http://msdn2.microsoft.com/library/ms182132(VS.90).aspx [none] Error COM visible type base types should be COM visible COM visible types should have an object hierarchy that is uniformly COM visible. {0} is marked ComVisible(true) but has the following ComVisible(false) types in its object hierarchy: {1} http://msdn2.microsoft.com/library/ms182202(VS.90).aspx [none] Error Compound words should be cased correctly Avoid creating compound words from terms which exist in the dictionary as discrete terms. Do not create a compound word such as 'StopWatch' or 'PopUp'. These terms are recognized in the dictionary and should be cased as 'Stopwatch' and 'Popup'. In member {0}, the discrete term '{1}' in parameter name {2} should be expressed as a compound word, '{3}'. http://msdn2.microsoft.com/library/bb264474(VS.90).aspx [none] Error Consider passing base types as parameters Using base types as parameters to methods improves re-use of these methods if you only use methods & properties from the parameter's base class. E.g. use Stream instead of FileStream as a parameter when only calling Stream.Read(), this makes the method work on all kind of streams instead of just File streams. Consider changing the type of parameter {0} in {1} from {2} to its base type {3}. This method appears to only require base class members in its implementation. Suppress this violation if there is a compelling reason to require the more derived type in the method signature. http://msdn2.microsoft.com/library/3hk32yyz(VS.90).aspx [none] Error Declare event handlers correctly By convention, .NET events have two parameters that specify the event sender and event data. Event handler signatures should follow this form: void MyEventHandler(object sender, EventArgs e). The 'sender' parameter is always of type System.Object, even if it is possible to employ a more specific type. The 'e' parameter is always of type System.EventArgs. Events that do not provide event data should use the System.EventHandler delegate type. Event handlers return void so that they can send each event to multiple target methods. Any value returned by a target would be lost after the first call. Declare the first parameter of {0} as an object named 'sender'. Declare the second parameter of {0} as an EventArgs, or an instance of a type that extends EventArgs, named 'e'. http://msdn2.microsoft.com/library/ms182133(VS.90).aspx [none] Error Define accessors for attribute arguments Provide accessors for both named and positional arguments. Each positional argument on an attribute should declare a read-only property with the same name (but different casing). Each named argument should provide a read/write property with the same name (but different casing). Add a public read-only property accessor for positional argument {0} of Attribute {1}. Remove the property setter from {0} or reduce its accessibility because it corresponds to positional argument {1}. http://msdn2.microsoft.com/library/ms182136(VS.90).aspx [none] Error Do not declare read only mutable reference types A read-only declaration for a mutable reference type does not prevent the field's instance data from being modified. For example, a read-only StringBuilder field declaration does not make sense, since the data encapsulated by the StringBuilder can be modified using the read-only reference. Remove the read-only designation from {0} or change the field to one that is an immutable reference type. If the reference type {1} is, in fact, immutable, exclude this message. http://msdn2.microsoft.com/library/ms182302(VS.90).aspx [none] Error Do not declare visible instance fields Instance fields that are visible outside of the type that declares them, limit your ability to change the implementation details for those data items. Use properties instead. They do not compromise usability or performance and they do provide flexibility in that they conceal the implementation details of the underlying data. Because field {0} is visible outside of its declaring type, change its accessibility to private and add a property, with the same accessibility as the field has currently, to provide access to it. http://msdn2.microsoft.com/library/ms182141(VS.90).aspx [none] Error Identifiers should be spelled correctly The individual words that make up an identifier should not be abbreviated and should be spelled correctly. If this rule generates a false positive on a term that should be recognized, add the word to the FxCop custom dictionary. In method {0}, consider providing a more meaningful name than parameter name {1}. http://msdn2.microsoft.com/library/bb264492(VS.90).aspx [none] CriticalWarning Identifiers should not contain type names Avoid using language-specific types name in parameters and members and data type identifiers in parameters. Types names might not be intuitive for all developers. It is recommended that you select a generic name, such as 'value', instead. If this is not sufficient, be sure to use the type name as it is defined in the .NET Framework Library and avoid language-specific type names completely. Some examples of C#-specific type names are 'float' (use 'Single' if a generic name is not sufficient), and 'ulong' (use 'UInt64' if a generic name is not sufficient). In member {0}, consider replacing the data type identifier '{1}' in parameter name {2} with a more generic term, such as 'value'. http://msdn2.microsoft.com/library/ms182234(VS.90).aspx [none] Error Mark assemblies with CLSCompliantAttribute Assemblies should explicitly state their CLS compliance using the CLSCompliant attribute. An assembly without this attribute is not CLS-compliant. Assemblies, modules, and types can be CLS-compliant even if some parts of the assembly, module, or type are not CLS-compliant. The following rules apply: 1) If the element is marked CLSCompliant, any noncompliant members must have the CLSCompliant attribute present with its argument set to false. 2) A comparable CLS-compliant alternative member must be supplied for each member that is not CLS-compliant. Mark {0} with CLSCompliant(true) because it exposes externally visible types. http://msdn2.microsoft.com/library/ms182156(VS.90).aspx [none] Error Mark assemblies with ComVisibleAttribute The System.Runtime.InteropServices.ComVisible attribute indicates whether COM clients can use the library. Good design dictates that developers explicitly indicate COM visibility. The default value for this attribute is 'true'. However, the best design is to mark the assembly ComVisible false, and then mark types, interfaces, and individual members as ComVisible true, as appropriate. Because {0} exposes externally visible types, mark it with ComVisible(false) at the assembly level and then mark all types within the assembly that should be exposed to COM clients with ComVisible(true). http://msdn2.microsoft.com/library/ms182157(VS.90).aspx [none] CriticalError, Error Mark members as static Methods which do not access instance data or call instance methods can be marked as static (Shared in Visual Basic). After doing so, the compiler will emit non-virtual call sites to these members which will prevent a check at runtime for each call that ensures the current object pointer is non-null. This can result in a measurable performance gain for performance-sensitive code. In some cases, the failure to access the current object instance represents a correctness issue. The 'this' parameter (or 'Me' in Visual Basic) of {0} is never used. Mark the member as static (or Shared in Visual Basic) or use 'this'/'Me' in the method body or at least one property accessor, if appropriate. http://msdn2.microsoft.com/library/ms245046(VS.90).aspx [none] Warning Members should not expose certain concrete types Members should not expose certain concrete types. Modify member {0} so that it no longer exposes the concrete type {1}. Use IXPathNavigable to represent XML data sources. http://msdn2.microsoft.com/library/ms182160(VS.90).aspx [none] Error Parameter names should match base declaration For usability reasons, parameter names in overridden methods should match those of the base declaration. In member {0}, change parameter name {1} to {2} in order to match the identifier as it has been declared in {3}. http://msdn2.microsoft.com/library/ms182251(VS.90).aspx [none] Error Parameter names should not match member names Parameter names should be distinct from member names. Change either member or parameter name {0} so that one differs from the other. http://msdn2.microsoft.com/library/ms182252(VS.90).aspx [none] Error Specify IFormatProvider If an overload exists that takes an IFormatProvider argument, it should always be called in favor of an overload that does not. Some methods in the runtime convert a value to or from a string representation and take a string parameter that contains one or more characters, called format specifiers, which indicate how the value is to be converted. If the meaning of the format specifier varies by culture, a formatting object supplies the actual characters used in the string representation. In scenarios where sorting and comparison behavior should never change between cultures, specify CultureInfo.InvariantCulture, otherwise, specify CultureInfo.CurrentCulture. Because the behavior of {0} could vary based on the current user's locale settings, replace this call in {1} with a call to {2}. If the result of {2} will be displayed to the user, specify 'CultureInfo.CurrentCulture' as the 'IFormatProvider' parameter. Otherwise, if the result will be stored and accessed by software, such as when it is persisted to disk or to a database, specify 'CultureInfo.InvariantCulture'. http://msdn2.microsoft.com/library/ms182190(VS.90).aspx [none] Error Specify StringComparison If an overload exists that takes a StringComparison argument, it should always be called in favor of an overload that does not. {0} makes a call to {1} that does not explicitly provide a StringComparison. This should be replaced with a call to {2}. http://msdn2.microsoft.com/library/bb386080(VS.90).aspx [none] Error Static holder types should not have constructors Instances of types that define only static members do not need to be created. Many compilers will automatically add a public default constructor if no constructor is specified. To prevent this, adding an empty private constructor may be required. Remove the public constructors from {0}. http://msdn2.microsoft.com/library/ms182169(VS.90).aspx [none] Error Type names should not match namespaces Identifiers which conflict in whole or in part with namespace names should be avoided. Names that describe the purpose or contents of a type are preferred. The type name {0} conflicts in whole or in part with the namespace name '{1}'. Change either name to eliminate the conflict. http://msdn2.microsoft.com/library/ms182257(VS.90).aspx [none] Error Types should not extend certain base types It is best not to extend some base types or to prefer extending better alternatives to those base types. Change the base type of {0} so that it no longer extends {1}. This base exception type does not provide any additional value for framework classes. Extend 'System.Exception' or an existing unsealed exception type instead. Do not create a new exception base type unless there is specific value in enabling the creation of a catch handler for an entire class of exceptions. http://msdn2.microsoft.com/library/ms182171(VS.90).aspx [none] Error Types that own disposable fields should be disposable Types that declare disposable members should also implement IDisposable. If the type does not own any unmanaged resources, do not implement a finalizer on it. Implement IDisposable on {0} because it creates members of the following IDisposable types: {1}. If {0} has previously shipped, adding new members that implement IDisposable to this type is considered a breaking change to existing consumers. http://msdn2.microsoft.com/library/ms182172(VS.90).aspx [none] CriticalError URI properties should not be strings If a property name contains "uri" or "url" or "urn" and it's typed as string, it should be changed to System.Uri. Change the type of property {0} from string to System.Uri. http://msdn2.microsoft.com/library/ms182175(VS.90).aspx [none] Error Use literals where appropriate Prefer literals over InitOnly fields if values do not have to be calculated at runtime. Field {0} is declared as 'static readonly' but is initialized with a constant value '{1}'. Mark this field as 'const' instead. http://msdn2.microsoft.com/library/ms182280(VS.90).aspx [none] Warning Category Certainty Collapse All Check Id Error error(s) Expand All Help Line message(s) [Location not stored in Pdb] Project Resolution Rule Rule File Rule Description Source Status Target Warning warning(s) Code Analysis Report